Problem/Motivation

Be ready for Drupal 9.

Proposed resolution

Remaining deprecation notices (16)

  8x: FileSystem::uriScheme() is deprecated in drupal:8.8.0. It will be removed from drupal:9.0.0. Use \Drupal\Core\StreamWrapper\StreamWrapperManagerInterface::getScheme() instead. See https://www.drupal.org/node/3035273
    8x in UtilityTest::testSanitizePath from Drupal\Tests\potion\Kernel

  8x: file_stream_wrapper_valid_scheme() is deprecated in drupal:8.0.0 and will be removed before drupal:9.0.0. Use \Drupal\Core\StreamWrapper\StreamWrapperManagerInterface::isValidScheme() instead. See https://www.drupal.org/node/3035273
    8x in UtilityTest::testSanitizePath from Drupal\Tests\potion\Kernel

Remaining tasks

CommentFileSizeAuthor
#4 3090755-04.patch9.9 KBStevenAvelino
#2 3090755-02.patch569 byteswengerk

Comments

wengerk created an issue. See original summary.

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
Status: Active » Needs review
StatusFileSize
new 3090755-02.patch569 bytes

Let's test the patch

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
Issue summary: View changes
StevenAvelino’s picture

StevenAvelino commented
StatusFileSize
new 3090755-04.patch9.9 KB

Let's run the patch to check for possible compatibility issues.

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented

Many thanks for your help on this project @StevenAvelino !!

Here is my tiny review

  1. +++ b/src/Utility.php
@@ -25,11 +25,11 @@ class Utility {
-   * The file system service.
-   *
-   * @var \Drupal\Core\File\FileSystemInterface
+   * Provides a StreamWrapper manager
+   * ¶
+   * @var \Drupal\Core\StreamWrapper\StreamWrapperManagerInterface
    */
-  protected $fileSystem;
+  protected $streamWrapper;

    Should be

    /**
   * The stream wrapper manager.
   *
   * @var \Drupal\Core\StreamWrapper\StreamWrapperManagerInterface
   */
  protected $streamWrapperManager;
  2. +      - '@stream_wrapper'

    should be '@stream_wrapper_manager'

  3. +++ b/tests/modules/potion_test/potion_test.info.yml
@@ -2,7 +2,13 @@ name: Potion test
+# core: 8.x

    It not necessary, remove but it's not necessary to add it as a comment. 

  4. +++ b/tests/modules/potion_test/potion_test.info.yml
@@ -2,7 +2,13 @@ name: Potion test
+
+# Information added by Drupal.org packaging script on 2019-08-16
+version: '8.x-1.0-alpha2'
+core: '8.x'
+project: 'potion'
+datestamp: 1565962416

    Those line should not be added.

wengerk’s picture

wengerk
he/him
Primary language French
Location Lausanne
commented
Status: Needs review » Fixed

fixed since 2.x release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.