Hi,

I have just started using this module and it seems great so far. However, I get the following strict warnings after the installation:
Strict warning: Only variables should be passed by reference in popup_element() (Zeile 214 von ...sites\all\modules\popup\includes\popup.api.inc).

This warning appears on each and every single page of my test installation - no matter whether popup is used on that very page or not. Sometimes the warning appears only 5 times on a page. On other pages the whole screen is filled with it (which is why I uninstalled it for now).

Thanks a lot in advance for a hint on how to avoid this warning.

CommentFileSizeAuthor
#2 popup-strict_warnings-1748290-1.patch3.61 KBScheepers de Bruin

Comments

Scheepers de Bruin’s picture

Scheepers de Bruin commented

For now, you can change this:

  $ajax_type = array_shift(
    array('text', 'node', 'block', 'form', 'view', 'php'),
    array_keys($attributes)
  );

To:

  $ajax_types = array_intersect(
    array('text', 'node', 'block', 'form', 'view', 'php'),
    array_keys($attributes)
  );
  $ajax_type = array_shift(
    $ajax_types
  );
Scheepers de Bruin’s picture

Scheepers de Bruin commented
Status: Active » Patch (to be ported)
StatusFileSize
new popup-strict_warnings-1748290-1.patch3.61 KB

Found some other places where this might happen too.

Scheepers de Bruin’s picture

Scheepers de Bruin commented
Status: Patch (to be ported) » Closed (fixed)