Hello,
Here is a problem I often regret when I use Drupal: access rights are not enough granular.
In this case, the problem is that we want users to be able to administer nodes, but not to be able to set initial votes counts.
The modifications we made on poll.module are attached.
Can I have some feedback and your opinion on what we've done?
Thank you,
David
PS: we may have the same problem concerning the separation of "set node author" from "administer nodes", what do you think of this one?
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | poll_change_votes_count_access_1.patch | 1.73 KB | David Stosik |
| #2 | poll_change_votes_count_access_0.patch | 1.57 KB | David Stosik |
| poll_change_votes_count_access.patch | 1.33 KB | David Stosik |
Comments
Comment #1
Anonymous (not verified) commentedI think the idea is fine but you need to standardize the comments. You can find the standards at [1] as well as other helps. You can also follow the example of the existing comments.
[1] http://drupal.org/handbooks
Comment #2
David Stosik commentedThank you.
I modified the comments in this version.
David
Comment #3
David Stosik commentedI corrected my patch behaviour. Now, "set vote counts" and "set poll settings" (active or closed, and poll duration) user access rights are separated from "administer nodes".
Comment #4
JirkaRybka commentedI'm afraid that new features now go into Drupal 7 branch only. Otherwise seems to me like a minor, but somewhere useful change, which may not hurt to have. :)
Comment #5
birdmanx35 commentedThis no longer works against HEAD.
Comment #6
Jaza commentedMoving.
Comment #7
alexpottPoll is no longer part of core
Comment #8
adammalonePoll module as it currently stands allows poll votes to be manipulated via the node/%node/edit page.
The way I see it, if there is to be an additional permission for setting poll votes then perhaps it should be on a different tab (either node/%node/votes or a new one) with access granted to that with the as yet implemented permission.
Comment #9
adammalonePoll is now its own entity and now no longer relies on node permissions. In the near future I envisage further permissions to allows polls to be created and votes manipulated. This can be addressed further as part of those changes.
Comment #10
berdirI'm marking this as fixed since it "just" requires the administer polls permission now. If more specific permissions are needed, then I think separate feature requests for that are better.