Problem/Motivation

On Drupal 12 the plugin module is broken. We can update code in preparation as this code works on both Drupal 11 and Drupal 12.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork plugin-3588790

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review

alexpott opened merge request !14

berdir made their first commit to this issue’s fork.

joachim’s picture

joachim commented

Shouldn't this use DeprecationHelper?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I'm not very fond of the DeprecationHelper, I don't find it very readable, but the float based check certainly is pretty unusual, I usually do a version_compare().

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Changed to version_compare...

Personally I find the (float) thing way more readable and easier to parse in my head as it uses a comparison operator against the version while version_compare you are comparing against a 0 which is wierd.