Problem/Motivation

For a project there is a need to add events (scroll, search pages...) that I think could be more generic and pushed to the main project.

User interface changes

New checkboxes in back-office to activate or not said events

Data model changes

The checkboxes add new flags in configuration, but since checkboxes are not checked by default, there is no need to automatically update data model.

Issue fork pianoanalytics-3572302

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

funstenolf created an issue. See original summary.

funstenolf opened merge request !22

mably’s picture

mably commented
Status: Active » Needs work

Check my MR comments. We have too specific conditions in there.

May be we should use selectors or something equivalent. Ideas welcome.

funstenolf’s picture

funstenolf commented
Status: Needs work » Needs review

I changed both hard coded values into configurable settings, and added them into the schema definition yaml.

Don't hesitate to give more feedback.

funstenolf closed merge request !22

funstenolf’s picture

funstenolf commented
Status: Needs review » Needs work