Closed (fixed)
Project:
Portable Game Notation (PGN)
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
2 Apr 2013 at 15:15 UTC
Updated:
4 Jan 2014 at 02:58 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
eric_a commentedThis is the PGNXML encoder.
Comment #3
eric_a commentedComment #5
eric_a commentedComment #7
eric_a commentedThat was a truly terrible try... and of course it did not work.
Comment #8
eric_a commentedComment #10
eric_a commentedComment #11
eric_a commentedWhite space fixes...
Comment #12
eric_a commentedAdded XML namespace to root element.
Comment #13
eric_a commentedTest decoding.
Comment #15
eric_a commentedComment #17
eric_a commentedComment #18
eric_a commentedApparently the Symfony XmlEncoder does not handle the namespace. Let's just do that ourselves.
Comment #19
eric_a commentedIntroduced injection of the Symfony Encoder. (We'll do some mocking in a separate D8-only issue.)
No changes to the test.
Comment #21
eric_a commented#19: pgn-encoder-1959028-19.patch queued for re-testing.
Comment #22
eric_a commentedComment #23
eric_a commentedComment #24
eric_a commentedComment #25
eric_a commentedPushed to 8.x-1.x. Moving to 7.x-1.x.
Comment #26
eric_a commented#1970094: Convert XmlEncoderUnitTest to a UnitTestBase has landed, so now we have a type of test that has an equivalent in Drupal 7.
Comment #28
eric_a commentedComment #29
eric_a commented#26: pgn-encoder-1959028-26.patch queued for re-testing.
Comment #30
eric_a commentedPushed #26 to 7.x-1.x.