Problem/Motivation

It is not D11 compatible

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

dahousecat created an issue. See original summary.

dahousecat’s picture

StatusFileSize
new823 bytes

adam-vessey made their first commit to this issue’s fork.

adam-vessey’s picture

Version: 1.0.1 » 1.0.x-dev

This is in an odd state. The "lenient" endpoint doesn't even allow the module to be installed acquired via Composer, possibly because of the unexpected namespace mjordan/persistent_identifiers instead of drupal/persistent_identifiers? And then because the "lenient" endpoint isn't working for this, it's not actually possible to test this patch for D11?

That said, is quite a straight-forward patch. Went and effected much the same change in a MR.

adam-vessey’s picture

Status: Active » Needs review
adam-vessey’s picture

Assigned: Unassigned » adam-vessey
Status: Needs review » Needs work

The submodules also need adjustment.

adam-vessey’s picture

Tossed at upgrade_status; appears to be a number of other things to be addressed, will adjust the MR accordingly.

adam-vessey’s picture

Actually... something very odd going on here? Things seem to be tangled up with https://www.drupal.org/project/persistent_ids ?

$ composer show -a drupal/persistent_identifiers
name     : drupal/persistent_identifiers
descrip. : Drupal 8 Module that provides a generalized framework for minting and persisting persistent identifiers (DOIs, ARKs, etc.) for Drupal nodes.
keywords :
versions : 1.0.x-dev, 1.0.0, dev-1.0.x
type     : metapackage
license  : GNU General Public License v2.0 or later (GPL-2.0+) (OSI approved) https://spdx.org/licenses/GPL-2.0+.html#licenseText
homepage : https://www.drupal.org/project/persistent_ids
source   : []
dist     : []
names    : drupal/persistent_identifiers

support
source : https://git.drupalcode.org/project/persistent_ids

requires
drupal/persistent_ids ^1
drupal/core ^8 || ^9 || ^10

... a metapackage with requirement on drupal/persistent_ids, with it as the homepage/source? Despite trying to deal with drupal/persistent_identifiers explicitly? Seems to be running into this class of issue: https://drupal.slack.com/archives/C223PR743/p1670877303918219?thread_ts=...

Apparently, can reference it appropriately with drupal/persistent_identifiers-persistent_identifiers:

$ ddev composer show -a drupal/persistent_identifiers-persistent_identifiers
name     : drupal/persistent_identifiers-persistent_identifiers
descrip. : Drupal 8 Module that provides a generalized framework for minting and persisting persistent identifiers (DOIs, ARKs, etc.) for Drupal nodes.
keywords : Drupal
versions : 1.0.x-dev, 1.0.1, 1.0.0, dev-1.0.x
type     : drupal-module
license  : GNU General Public License v2.0 or later (GPL-2.0+) (OSI approved) https://spdx.org/licenses/GPL-2.0+.html#licenseText
homepage : https://github.com/mjordan/persistent_identifiers
source   : [git] https://git.drupalcode.org/project/persistent_identifiers.git 084d080104484edb1d6c8c71dcbb22f8c37f1a63
dist     : []
names    : drupal/persistent_identifiers-persistent_identifiers

support
source : https://git.drupalcode.org/project/persistent_identifiers

requires
drupal/core ^8 || ^9 || ^10

... looking again, this other name _is_ reflected in the install line of the project page, just... yeah, rather unexpected, which probably lead to it being installed with the other name in the given environment.

adam-vessey’s picture

Assigned: adam-vessey » Unassigned
Status: Needs work » Needs review

Dealt with the other bits there now, in MR 5.

That said, less stress on getting this merged, as I'm assuming that using the correct (drupal/persistent_identifiers-persistent_identifiers) name with the lenient endpoint/plugin should allow things to work with patching.