I plan to enhance pdfview with extending the class.

Currently, it is not easy to change the pages' header and footer. PHP allows us to overwrite specific methods with own methods.
Beside this we can overwrite Error() so that errors get logged with watchdog.

You can get a first impression about this if you take a look at the files attached

CommentFileSizeAuthor
#2 pdfview_theme.inc_.txt4.95 KBTobias Maier
#1 pdfview_tcpdf.inc_.txt990 bytesTobias Maier
pdfview.image__4.patch6 KBTobias Maier

Comments

Tobias Maier’s picture

Tobias Maier commented
Status: Active » Needs review
StatusFileSize
new pdfview_tcpdf.inc_.txt990 bytes

this is the class extension

Tobias Maier’s picture

Tobias Maier commented
StatusFileSize
new pdfview_theme.inc_.txt4.95 KB

I moved every theme function into this include except theme_pdfview_pdf()

tzafrir’s picture

tzafrir commented

Wow, this is a very good step for pdfview!

Right now I cannot use it, because of the messy images, the error handling, and the problems with headering, so this is very good news to hear!

Egon Bianchet’s picture

Egon Bianchet commented

Let's discuss the future of pdfview here before going ahead: http://groups.drupal.org/pdf

rconstantine’s picture

rconstantine commented

Any progress on this?