Problem/Motivation
In Drupal 9, 7 and 8page number input and pdf ratio input is not aligned with pdf navbar when using pdf.js as renderer as shown in figure.
Steps to reproduce
1. Install module.
2. Configure as shown.
3. Choose pdf.js as renderer.
4. Upload pdf and check.
Proposed resolution
for drupal 9 add this in css file:
#pageNumber{
padding: 0;
color: white;
min-height: 22px;
margin-right: 2px;
margin-left: -6px;
text-align: center;
min-width: 68px;
}
#scaleSelect{
padding-left: 0.125rem;
padding-right: 2.375rem;
height: 100%;
}
for drupal 7 and 8 ass this in css file:
add margin-right: -16px; in html[dir='ltr'] .outerCenter
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | Error pdf.png | 172.29 KB | Aamir M |
| #8 | 3310073-8.patch | 476 bytes | Junaid_Nayeem |
| #5 | 3310073-5.patch | 340 bytes | chaubeyji |
Issue fork pdf_reader-3310073
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
chaubeyji commentedComment #3
chaubeyji commentedComment #4
Pracheth commentedI will work on this issue
Comment #5
chaubeyji commentedThis fix is for drupal 7
Comment #6
chaubeyji commentedComment #7
chaubeyji commentedComment #8
Junaid_Nayeem commentedCreated a patch for d9 and d10 versions as you suggested in the proposed resolution.
Comment #9
Aamir M commentedVerified patch #8 on Drupal 9.4.x. It's showing an error and is also incompatible with the Drupal 10.0 version
A screenshot is attached for reference
Comment #10
chaubeyji commentedhey hi @Aamir M Apply https://www.drupal.org/files/issues/2022-07-18/pdf_reader.1.x-dev.rector... first and then try again. It is working fine after this.
Comment #11
Aamir M commentedHi @chaubeyji, I have verified the path (#10) provided by you. It's applied successfully and working for me.
And it's also compatible with Drupal 10.0. Thanks.
Comment #12
penyaskitoScreenshots would be helpful, it's hard to appreciate any difference.
Also would need: rtl versions, @media queries for the different breakpoints.