Check of valid extension seems to be duplicated in the create case

The function _patterns_io_file_has_valid_extension() is called twice, we can probably then remove it on the parent function since it is ensured in the inner one:

includes/forms/import.inc - l.360

  // Add the extension if missing or invalid
  if (!_patterns_io_file_has_valid_extension($name)) {
    $name = $name . '.' . $format;
  }

includes/io/io.inc - l.395

  // Check if the file has a valid extension
  // and in case add the format at the end
  if (!_patterns_io_file_has_valid_extension($name)) {
    $name = $name . '.' . $format;
  }

As Stefano suggested we should be careful about this: "Some function calls are a bit entangled, so we must be careful in removing double checkings. Require testings, if you remove it".

I will create a branch of the code at github, take a look to remove it and test if no other functions get affected. I will provide a patch if everything is ok.

Cheers,

David