It's possible that the tests don't work, we should check.

CommentFileSizeAuthor
#8 pathinc-2607632-tests.patch7.83 KBsteven jones
#3 pathinc-2607632-tests-not-working.patch11.77 KBsteven jones

Comments

Steven Jones created an issue. See original summary.

steven jones’s picture

steven jones commented

Yeah so the issue here is that because the module is enabled and tested in the same PHP request, it's using the Drupal core versions of the functions in path.inc, and not loading our version.

steven jones’s picture

steven jones commented
Status: Active » Needs review
StatusFileSize
new pathinc-2607632-tests-not-working.patch11.77 KB

Fairly certain these will fail.

Status: Needs review » Needs work

The last submitted patch, 3: pathinc-2607632-tests-not-working.patch, failed testing.

The last submitted patch, 3: pathinc-2607632-tests-not-working.patch, failed testing.

The last submitted patch, 3: pathinc-2607632-tests-not-working.patch, failed testing.

The last submitted patch, 3: pathinc-2607632-tests-not-working.patch, failed testing.

steven jones’s picture

steven jones commented
Status: Needs work » Needs review
StatusFileSize
new pathinc-2607632-tests.patch7.83 KB

Right, scale back the number of tests to things we can actually test, and run them in a test within a test.

steven jones’s picture

steven jones commented
Status: Needs review » Fixed

  • Steven Jones committed c7221bd on 7.x-1.x 
    Issue #2607632 by Steven Jones: Fix the tests to run in a sub...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.