7.x-1.0+5-dev

There's a few errors being thrown regarding undefined indexes in theme_patch_manager_issuelink() that seem to be due to spelling errors!

In particular:

'reviewed & tested by the communty' => 'state-14', should be 'reviewed & tested by the community' => 'state-14',

In addition, by looking at the results of $item it seems that there is a possible value of NULL for the status element. Since this is the case, a condition should be added to handle lack of status values.

A quick solution might be as so:

- patch_manager.module, theme_patch_manager_issuelink($item)

...
  // Add class for coloring depending on issue status.
  $status = $item['status'];
  if($item['status'] == NULL) $status = 'unknown';
  // Map issue status with class.
  $map = array(
    'active' => 'state-1',
    'fixed' => 'state-2',
    'closed (duplicate)' => 'state-3',
    'postponed' => 'state-4',
    "closed (won't fix)" => 'state-5',
    'closed (works as designed)' => 'state-6',
    'closed (fixed)' => 'state-7',
    'needs review' => 'state-8',
    'needs work' => 'state-13',
    'reviewed & tested by the community' => 'state-14',
    'patch (to be ported)' => 'state-15',
    'postponed (maintainer needs more info)' => 'state-16',
    'closed (cannot reproduce)' => 'state-18',
    'unknown' => 'state-19'
  );
...

Cheers!

Comments

emcniece’s picture

Issue summary: View changes

formatting

bohemier’s picture

Thanks for the hint. I tried to make an admin theme function to override theme_patch_manager_issuelink($item) but it didn't work (I also cleared caches) ... It seems this is not a real theme function? This function is broken and needs some work...