Hat reference field isn't working.

party_hat_options_list() seems to expect bundles.

Also, its incoming params are wrong and there seems to be no $instance coming through.

Comments

joachim’s picture

joachim commented
Status: Active » Fixed

- #1661934 by joachim: Fixed party_hat_options_list() still expecting party types; fixed parameters.

rlmumford’s picture

rlmumford
Primary language English
Location Manchester
commented
Status: Fixed » Active

I'm getting errors since the patch due to missing arguments. Was this function changed recently?

rlmumford’s picture

rlmumford
Primary language English
Location Manchester
commented
Status: Active » Fixed

Updated drupal to latest and we're fine.

joachim’s picture

joachim commented
Status: Fixed » Active

Ah yes. Oops.

That's created a dependency on core > 7.14 I think.
Do we want that? We could roll this back, it's not critical.

rlmumford’s picture

rlmumford
Primary language English
Location Manchester
commented

I think it's fine as long as we make a note of it.

joachim’s picture

joachim commented

Ok, we'll have to check which version of core added those variables.

joachim’s picture

joachim commented

Confirming this was added in 7.14~39, ie new in Drupal core 7.14.

rlmumford’s picture

rlmumford
Primary language English
Location Manchester
commented
Title: party_hat_options_list() broken - still expects bundles » Change Notification for party_hat_options_list() broken: Party requires Drupal >= 7.14

We should make a note somewhere.

joachim’s picture

joachim commented

I'm happy to add it as a requirement to the project page; I just wonder whether it's a good idea to force 7.14!

yautja_cetanu’s picture

yautja_cetanu commented

For a dev version of Party I think its fine to force 7:14... I think by the time Party is released it will be a very old version of Drupal

joachim’s picture

joachim commented
Status: Active » Fixed

Added to project page.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.