Looks like when bundles were removed from parties, party_user wasn't updated to match:

Call to undefined function party_get_party_types() in public_html/sites/all/modules/modified/party/modules/party_user/party_user.admin.inc on line 17, referer: admin/config

I suspect there will be a number of others also!

CommentFileSizeAuthor
#2 party-fix_party_user_bundle_data_set_issue-1644336-2.patch3.11 KBandrewbelcher
#1 party-fix_party_user_bundle_issue-1644336-1.patch2.78 KBandrewbelcher

Comments

andrewbelcher’s picture

andrewbelcher commented
Status: Active » Needs review
StatusFileSize
new party-fix_party_user_bundle_issue-1644336-1.patch2.78 KB

I think this patch fixes is, but I may have missed something...

andrewbelcher’s picture

andrewbelcher commented
Title: party_user still using party types (and getting PHP Fatal Error) » party_user not updated for bundles and new data controller
StatusFileSize
new party-fix_party_user_bundle_data_set_issue-1644336-2.patch3.11 KB

Found more issues, doesn't look like it was updated for the new data controller either... Got various errors on user sync:

Recoverable fatal error: Argument 2 passed to PartyDefaultDataSet::__construct() must be an instance of Party, null given, called in public_html/sites/all/modules/modified/party/party.module on line 696 and defined in PartyDefaultDataSet->__construct() (line 59 of public_html/sites/all/modules/modified/party/includes/party.data.inc).

Call to undefined method PartyUserDataSet::setAttachedEntity() in public_html/sites/all/modules/modified/party/modules/party_user/party_user.module on line 458, referer: batch?op=start&id=5

Call to undefined method PartyUserDataSet::attach() in public_html/sites/all/modules/modified/party/modules/party_user/party_user.module on line 464, referer: batch?op=start&id=6

I think the attached patch fixes it all (also includes the patch from #1)...

andrewbelcher’s picture

andrewbelcher commented
Status: Needs review » Needs work

Hmm... although it present me with success messages about having created 2 users on sync, it didn't actually do it...

joachim’s picture

joachim commented
Assigned: Unassigned » joachim

I'm working on this one today :)

joachim’s picture

joachim commented
Status: Needs work » Fixed

I've split this patch (git-fu: cherry-pick followed by a soft reset!!!!); committing the bundles fix here, and the rest I am merging into a new patch at #1612368: Clean up old controller uses.

Thanks for working on this!

Issue #1644336 by andrewbelcher: Fixed party_user for removal of party bundles.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.