Problem/Motivation

As proposed in the parent issue, user should be able to have "duplicate" feature in all 3 modes. Currently it is working only in "preview" and "closed".

CommentFileSizeAuthor
#8 interdiff-2851409-3-8.txt2.57 KBtoncic
#8 enable_duplicate-2851049-8.patch4.83 KBtoncic
#3 edit_paragraphs_closed_mode.png50.39 KBtoncic
#3 edi_paragraphs_open_mode.png48.62 KBtoncic
#3 enable_duplicate-28510490-2.patch2.26 KBtoncic

Comments

drobnjak created an issue. See original summary.

toncic’s picture

toncic commented
Assigned: Unassigned » toncic

I will do this one. ;)

toncic’s picture

toncic commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new enable_duplicate-28510490-2.patch2.26 KB
new edi_paragraphs_open_mode.png48.62 KB
new edit_paragraphs_closed_mode.png50.39 KB

There it is. Now we have duplicate option on all 3 modes.
Providing screenshot.

drobnjak’s picture

drobnjak commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

drobnjak’s picture

drobnjak commented
Status: Reviewed & tested by the community » Needs review

Mistake, waiting tests first.

drobnjak’s picture

drobnjak commented
Status: Needs review » Reviewed & tested by the community

Now RTBC

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs work

I additionally requested an assert for button visibility.

toncic’s picture

toncic commented
Status: Needs work » Needs review
StatusFileSize
new enable_duplicate-2851049-8.patch4.83 KB
new interdiff-2851409-3-8.txt2.57 KB

We have function for testing buttons visibility.

  • miro_dietiker committed 8032b9a on 8.x-1.x authored by toncic 
    Issue #2851049 by toncic, drobnjak: Enable "duplicate paragraphs"...
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Fixed

Committed, thx :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.