The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.This is a minor issue, but I am getting this PHP warning on every page load where I'm using this cache plugin:
Notice: Undefined property: panels_display::$cache_key in panels_hash_cache_get_id() (line 91 of sites/all/modules/contrib/panels_hash_cache/plugins/cache/panels_hash_cache.inc).
I've attached a possible patch for this issue that checks isset($display->cache_key). I'm not sure where/when the cache_key property would be set, or whether you would want to include some other piece of data in the hash when that value is missing, so I'm open to other fixes.
Thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 1405900-mini_panels_css_id-nodpm.patch | 652 bytes | benclark |
| #1 | 1405900-mini_panels_css_id.patch | 849 bytes | benclark |
| panels_hash_cache.cache_key_warning.patch | 572 bytes | benclark |
Comments
Comment #1
benclark commentedTurns out, panels_mini blocks don't have $display->cache_id set because according to the maintainer, they don't support the IPE. They do have $display->css_id, which is unique per block.
In the Simple cache plugin, they have added $display->css_id when $display->cache_id is empty (see #1349118: Simple Caching ID scheme will lead to conflicts with exported Panels definitions). This fixes support for panels_mini blocks. I have adjusted my earlier patch to follow the same sort of logic.
Comment #2
benclark commented*sigh* Sorry to keep spamming this issue, but I left some debug output in my previous patch.
Comment #3
phayes commentedCommitted! THanks!
Comment #5
aschiwi commented-edit- commented on wrong issue