Problem/Motivation

Let's do this dance, folks. Panelizer, like Layout Builder, stores entity-specific layout data in its own field. That data needs to be migrated to Layout Builder.

Proposed resolution

Write a test for this, then fix it.

Remaining tasks

Patch, tests, commit. Standard procedure.

User interface changes

None.

API changes

None.

Data model changes

TBD, but likely no changes to existing data.

Release notes snippet

None.

CommentFileSizeAuthor
#14 3071434-14.patch29.72 KBphenaproxima
#12 3071434-12.patch25.56 KBphenaproxima
#11 3071434-11.patch17.68 KBphenaproxima
#8 3071434-8.patch15.96 KBphenaproxima
#7 interdiff-3071434-6-7.txt2.91 KBphenaproxima
#7 3071434-7.patch11.07 KBphenaproxima
#6 interdiff-3071434-5-6.txt4.24 KBphenaproxima
#6 3071434-6.patch9.28 KBphenaproxima
#5 3071434-5.patch9.29 KBphenaproxima
#3 3071434-3-FAIL.patch4.74 KBphenaproxima
#2 3071434-2.patch2.19 KBphenaproxima

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Needs review
StatusFileSize
new 3071434-2.patch2.19 KB

Initial pass, without tests.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3071434-3-FAIL.patch4.74 KB

Here's a failing test...

Status: Needs review » Needs work

The last submitted patch, 3: 3071434-3-FAIL.patch, failed testing. View results

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 3071434-5.patch9.29 KB

Made the test pass, albeit in a slightly hacky way. That's okay -- it proves the migration works! Now it's just a question of refactoring.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3071434-6.patch9.28 KB
new interdiff-3071434-5-6.txt4.24 KB

A little refactoring to trigger the entity-specific migration via the UI.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3071434-7.patch11.07 KB
new interdiff-3071434-6-7.txt2.91 KB

Now let's make it a batch job. :)

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3071434-8.patch15.96 KB

More refactoring, and wrapping everything into a batch job.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: Migrate entity-specific Panelizer data in the default language to Layout Builder » Migrate entity-specific Panelizer data in the default language and revision to Layout Builder

Re-titling to explain more clearly what this implements.

Status: Needs review » Needs work

The last submitted patch, 8: 3071434-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 3071434-11.patch17.68 KB

This should fix the failures.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3071434-12.patch25.56 KB

Expanded the test coverage to users and taxonomy terms.

Status: Needs review » Needs work

The last submitted patch, 12: 3071434-12.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 3071434-14.patch29.72 KB

This should fix the failures. Again.

  • phenaproxima committed a092329 on 8.x-5.x 
    Issue #3071434 by phenaproxima: Migrate entity-specific Panelizer data...
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.