Unchecking the "Create new revision" checkbox on the panelizer editing pages doesn't have any effect, a new revision is always created.
In order to get the "Create new revision" checkbox to appear on the panelizer pages, you need to check "Create new revision" on the edit content type page, which may or may not have anything to do with the problem.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | panelizer-n1804156-9.patch | 884 bytes | damienmckenna |
| #8 | panelizer-n1804156-8.patch | 884 bytes | damienmckenna |
| #5 | panelizer-n1402860-14-d7_2.patch | 474 bytes | damienmckenna |
Comments
Comment #1
damienmckennaPlease try the patch in #1402860: Panelizer is incompatible with moderation and let us know if it resolves the problem.
Comment #2
xen commentedIt somewhat works, see the comment in that issue.
Comment #3
esmerel commentedComment #4
xen commentedDupe? The other issue is about panelizer compatibility with workflow_moderation and other revision based moderation modules, while this is purely a bug report about panelizer always creating a new revision. Fixing this one does *not* fix the other, and the other might be marked wontfix due to deeper architectural incompatibilities, which could cause this, plain and simple, bug to slip through the cracks.
Rather, #1402860: Panelizer is incompatible with moderation should reference this as part of the bigger problem.
@DamienMcKenna Do you agree?
Comment #5
damienmckennaI concur.
This is my initial patch that appears to resolve the problem for the main Content page, but the others need work.
Comment #6
webkomplize commented@DamienMcKenna
What exactly do you mean with "...problem for the main Content page, but the others need work" ?
For me using the panelizer-n1402860-14-d7_2.patch does not prevent panelizer for creating revisions on IPE customizing panelizer page.
Also the patch from #1402860: Panelizer is incompatible with moderation does not work for me.
Would be really great to have a solution for this. Is there anything i can test, debug?
Comment #7
xen commented@webkomplize
For me, the patch worked in the regard that unchecking the 'create new revision' when saving the panel on the main editing page, caused it to not create a new version.
However, it still didn't work on the layout/context/etc. pages.
Comment #8
damienmckennaThis is an updated patch that, at least in my testing, lets the user edit all tabs and the "Create new revision" checkbox is properly adhered to.
Comment #9
damienmckennaSlight change to the comment.
Comment #10
damienmckennaMarked #1784032: "Create new revison" causes panelizer to revert to defaults as a duplicate.
Comment #11
damienmckennaMy patch from #9 above will apply to both the 7.x-2.x and 7.x-3.x branches but has only been tested with 7.x-2.x.
Comment #12
damienmckennaFYI I created a related issue: #1820882: Make node revisions use the node_view display
Comment #13
damienmckennaFYI the ability to view node revisions was a problem in CTools, see #1820882 for further details.
Comment #14
xen commentedI've tried saving on each subpage, and it doesn't create a new revision when instructed not too.
Looks good to me.
Comment #15
jweowu commented+1
#9 certainly appears to do the trick. New revisions are now only created when the checkbox is selected, and no errors were logged.
Thanks Damien.
Comment #16
damienmckennaI've committed the fix from #9 to both the 7.x-2.x and 7.x-3.x branches.