Follow up for #1943744: Create / edit menu item form.

Menu items who link to non-published nodes are not shown in the menu overview page. These need to be shown. We also need an extra column in the overview to show in which moderation state the node coupled to the link item is.

Comments

isolate’s picture

Assigned: Unassigned » isolate
Status: Postponed » Active
isolate’s picture

Assigned: isolate » Unassigned
Status: Active » Needs review
cyberwolf’s picture

Assigned: Unassigned » cyberwolf
cyberwolf’s picture

Assigned: cyberwolf » Unassigned
Status: Needs review » Needs work

Currently, when you link to a published node of which a draft revision is created and saved with workbench moderation, the status column of the menu item mentions "draft". This might be confusing, as there is actually a version of the node currently published. Instead of showing the workbench moderation state, we'd better just show "Published" and "Not published" depending on the node status.

Also, there is a hard dependency on workbench moderation introduced which is not mentioned in the .info file. Solving the previous problem will normally solve this problem as well.

isolate’s picture

Assigned: Unassigned » isolate
isolate’s picture

Assigned: isolate » Unassigned
Status: Needs work » Needs review

fixed

cyberwolf’s picture

Status: Needs review » Needs work

'moderation' should be called differently now as well, maybe 'node_status'?

cyberwolf’s picture

One last thing: the doc of paddle_menu_manager_tree_check_access() should be modified, to mention it's a variation on menu_tree_check_access() which shows unpublished nodes as well.

isolate’s picture

Status: Needs work » Needs review

fixed.

cyberwolf’s picture

Assigned: Unassigned » cyberwolf
cyberwolf’s picture

Looks good. Waiting for the tests to finish, if those succeed I will merge.

cyberwolf’s picture

Status: Needs review » Fixed

Merged. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.