Closed (fixed)
Project:
Paddle Menu Manager
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
28 Mar 2013 at 10:55 UTC
Updated:
19 Apr 2013 at 09:20 UTC
Follow up for #1943744: Create / edit menu item form.
Menu items who link to non-published nodes are not shown in the menu overview page. These need to be shown. We also need an extra column in the overview to show in which moderation state the node coupled to the link item is.
Comments
Comment #1
isolate commentedComment #2
isolate commentedComment #3
cyberwolf commentedComment #4
cyberwolf commentedCurrently, when you link to a published node of which a draft revision is created and saved with workbench moderation, the status column of the menu item mentions "draft". This might be confusing, as there is actually a version of the node currently published. Instead of showing the workbench moderation state, we'd better just show "Published" and "Not published" depending on the node status.
Also, there is a hard dependency on workbench moderation introduced which is not mentioned in the .info file. Solving the previous problem will normally solve this problem as well.
Comment #5
isolate commentedComment #6
isolate commentedfixed
Comment #7
cyberwolf commented'moderation' should be called differently now as well, maybe 'node_status'?
Comment #8
cyberwolf commentedOne last thing: the doc of paddle_menu_manager_tree_check_access() should be modified, to mention it's a variation on menu_tree_check_access() which shows unpublished nodes as well.
Comment #9
isolate commentedfixed.
Comment #10
cyberwolf commentedComment #11
cyberwolf commentedLooks good. Waiting for the tests to finish, if those succeed I will merge.
Comment #12
cyberwolf commentedMerged. Thanks!