The module hardcodes a limit of 100 members in a Class group. Why?

    // Limit the number of members in the class.
    if (!($bundle == 'opigno_class') || count($group->getMembers()) < 100) {

Can we please remove this limit, or at least make it configurable?

CommentFileSizeAuthor
#3 opigno_learning_path_class_limit-3211673-3.patch4.22 KBjatin12nov
#2 opigno_learning_path-configurable_class_limit-3211673-2.patch4.2 KBaaronbauman

Comments

AaronBauman created an issue. See original summary.

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Active » Needs review
StatusFileSize
new opigno_learning_path-configurable_class_limit-3211673-2.patch4.2 KB

This patch adds a setting to the existing learning_path_settings.

jatin12nov’s picture

jatin12nov
Primary language English
commented
StatusFileSize
new opigno_learning_path_class_limit-3211673-3.patch4.22 KB

I have created a patch for version 3.0.3

catch’s picture

catch
he/him
Primary language English
commented

I'm guessing this was added because several code paths in Opigno (especially adding/removing classes from learning paths) loop over every member of the class to add/remove them from the group, so once you get to several hundred class members there's a good chance of hitting memory limits.

These code paths are removed by #3083145: [PP-1] Add classes to learning paths, instead of individually adding all members which would be more reliable than trying to convert the existing logic to batch or similar.