WTK field populated with empty geometry GEOMETRYCOLLECTION() [#920418]

The problem occurs when saving a node leaving the WTK field empty: openlayers_behavior_drawfeatures_update() populates the WTK field with an empty geometry: GEOMETRYCOLLECTION().

When the same node is edited the empty geometry retrieved from the WTK field causes:

TypeError: features[i] is undefined { message="features[i] is undefined",  more...}

in openlayers_behavior_drawfeatures.js and it also prevents the "Draw Feature" behavior to show up correctly on the WTK map. A patch is attached.

Comment	File	Size	Author
#5	920418_accept_geometrycollection.patch	2.59 KB	tmcw
	openlayers-empty-geometry.patch	926 bytes	ademarco

Comments

Comment #1

ademarco commented 23 September 2010 at 11:20

Title:

Population WTK field with empty geometry GEOMETRYCOLLECTION()

» WTK field populated with empty geometry GEOMETRYCOLLECTION()

Choosing a better title. :)

Comment #2

tmcw commented 23 September 2010 at 17:31

Would a fix on the other side of this problem: making sure that drawfeatures can handle an empty features array - a GEOMETRYCOLLECTION() value - work as well for your use case? The code written in drawfeatures, and indeed, in the module needs to be robust to handle every valid/reasonable WKT input, I'd think.

Comment #3

ademarco commented 23 September 2010 at 19:56

Yes, it would work anyway and, indeed, the module must be able to handle any kind of valid WKT value. Which kind of solution you'd suggest?

Comment #4

tmcw commented 24 September 2010 at 09:41

Status:

Active

» Needs review

Here's a patch that makes sure that the module will readily accept GEOMETRYCOLLECTION(), by checking against the [undefined] array that it generates. This works for the types of input I can think of: single elements, blank, geometrycollection(elements) and geometrycollection().