With the big changes in the openid stack (http://groups.drupal.org/node/21221), openid_client_sreg stopped working.
Here is a patch what makes the module conforming to the new stack idea. The mapping is done via the openid_cp_field (via a hook, so no hard dependency).
I tested and it works fine. More testers wanted :)

CommentFileSizeAuthor
openid_client_sreg_make_work_with_openid_stack.patch10.31 KBaron novak

Comments

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented

Related (depending patches): #444170: Hook changes and client side SReg support and #444204: Hook change because of client side SReg support

alex_b’s picture

alex_b commented
Title: Make it work with the openid stack again » Make client SREG work with OpenID stack again
alex_b’s picture

alex_b commented

I see this patch removes an implementation of hook_openid_response() and replaces it with a custom callback on openid/authenticate - just like OpenID Client AX does.

We (Aron and I) discussed this on IM and we found that hook_openid_response() is not invoked by any existing OpenID module but it is being suggested here #329493: OpenID Road Map for Drupal by Darren Ferguson.

In favor of a functioning OpenID stack I think it's a good idea to replace the hook_openid_response() implementation with a callback on openid/authenticate just like this patch suggests.

We should start thinking about adding this hook_openid_response() into openid.module though.

alex_b’s picture

alex_b commented

Ok, just confirmed with Darren, #3 is ok with him, too.

We need to work on #319840: Add hook to the OpenID module for returning data to clean up this issue.

alex_b’s picture

alex_b commented
Status: Needs review » Reviewed & tested by the community

Just did another round of tests - RTBC.

alex_b’s picture

alex_b commented
Status: Reviewed & tested by the community » Fixed

Committed. Thank you!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.