The task here is to allow icons to be overridden in the theme, and that means the theme functions in OTW need to be rewritten.

CommentFileSizeAuthor
#4 custom_images_path_setting-1678872-4.patch2.03 KBgreenskin
#1 easier_to_override_icons-1678872-1.patch4.05 KBjenlampton

Comments

jenlampton’s picture

jenlampton
she / her
commented
Assigned: jenlampton » Unassigned
Status: Active » Needs review
StatusFileSize
new easier_to_override_icons-1678872-1.patch4.05 KB

Okay, here's a rewrite of the theme functions that make the icons easier to override.

jenlampton’s picture

jenlampton
she / her
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

greenskin’s picture

greenskin commented
Status: Closed (fixed) » Needs review
StatusFileSize
new custom_images_path_setting-1678872-4.patch2.03 KB

I like that you've added the theme functions, definitely makes things easier to alter. I'd like to offer one more patch against the 7.x-1.x version that simplifies using custom images without having to write any code. I've added a textfield to the settings fieldset in the block's configuration that allows setting the images folder path. Leaving it blank will default to the images folder within the module.

jenlampton’s picture

jenlampton
she / her
commented
Status: Needs review » Closed (fixed)

I think that's a great idea, can you open a new issue and attach the patch there (since this is a different request)? Thanks!