Each of my groups can create story items and each of them have their own vocabs to utilise. But when I create a generic story. i.e. from /node/add/story not /node/add/story?[og_group][]=x. I see all vocabs. I should not be able to see a groups vocabs unless I requested to create a group content item.

CommentFileSizeAuthor
#2 og_vocab.module.patch2.99 KBcooperaj

Comments

cooperaj’s picture

cooperaj commented

As an extention of this I seem unable to create site wide categories with this module installed. It inserts

$form['module'] = array('#type' => 'value', '#value' => 'og_vocab');

into all vocab add forms so hijacking all new vocabs. Old ones remain the same.

I'm working on fixing both these issues as IMO group vocabs sould be distinct separate entities to site vocabs.

cooperaj’s picture

cooperaj commented
Status: Active » Needs review
StatusFileSize
new og_vocab.module.patch2.99 KB

This patch seems to do the job.

*Only do og_vocab stuff when adding/editing an og_vocab
*Remove og_vocabs from a non og node. i.e. vanilla node/add/story NOT node/add/story?[og_group][]=X
*Remove breadcrumb setting stuff on Organic group category page. Unnecessary.

moshe weitzman’s picture

moshe weitzman commented

perhaps angie could take a look at this. the first part is a no brainer. not so sure about the rest after a quick read.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

adding to my list. no time to review atm, sorry.

rubenk’s picture

rubenk commented

Installed....seems to work fine. Would be nice if the admin area had a toggle to show or not show the categories to users WHOare members of the group when posting a node using the general posting form.

Does this obfuscate http://drupal.org/node/74564

rubenk’s picture

rubenk commented

It looks like this has caused people posting within a group to not be able to see a public category (taxonomy). e.g. I created a public taxonomy called document type and set this to apply to the book node. I also created a private taxonomy for one of the groups on my website. Now when they post using the group's "create book" button, they do not see the public taxonomy but only their private one. When they click the "create book" button from the normal (main) navigation menu (not associated with the group) they see the public taxonomy but not the private taxonomy.

I'd like them to be able to see public and private taxonomies if people belong to the group and only public ones when they do not belong to the group. If this module stays closer to the way it currently is, then a group member should at least be able to see the public tax (in addition to the private tax) when posting from within the group and only the public tax when posting from the main navigation menu.

Sorry if that was too long. If you need clarification, simply ask.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Fixed

fixed in a slightly different way.

if you also update og.module, you will see that posting without specifying any group on the url works decently now. at first, we no longer show you all group vocabs. once you do a preview with your selected group, then that groups vocab (and language and theme) show up on your form. calidation rules for that vocab like 'required' are enforced.

rubenk’s picture

rubenk commented

Wanted to follow up....the need to preview all posts was a little bit...annoying so I posted this forum topic. Maybe it is already possible do dynamically display form content as I proposed but I wanted to post a link here to that topic....

http://drupal.org/node/87851

rubenk’s picture

rubenk commented

bit of a bummer - i set everyone to have to review their post before submitting because of this...seems cumbersome.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)