See https://git.drupalcode.org/project/og/-/pipelines/614252

Also enforce all PHPUnit tests in .gitlab-ci.yml

Issue fork og-3549604

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

claudiu.cristea created an issue. See original summary.

joelpittet made their first commit to this issue’s fork.

joelpittet opened merge request !52

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

The code committed so far is addressing a different deprecation but I think the crux of the issue is related to routing params were magical and now they are not? I am scouring diffs to see where this change might originate.

The code so far is mostly trying to address https://www.drupal.org/node/3483599

joelpittet opened merge request !53

joelpittet changed the visibility of the branch 3549604-OgMembership-label to hidden.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

We could close this as duplicate or re-scope resolve the inevitable views.inc issue?

The main issue was fixed upstream in Drupal core #3551573: Avoid passing null from $entity->label() when no label key is defined in EntityListBuilder

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Related issues: +#3551573: Avoid passing null from $entity->label() when no label key is defined in EntityListBuilder
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Related issues: +#3548596: Add 'View' to operations links where available

joelpittet closed merge request !53

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Postponed

We don't need to make this change... yet, but we will for the views hooks. Postponing till this comes back as we have a solution. If you feel we should refactor now, please unpostpone. I'm taking a YAGNI approach here, only implement something that is an actual needed solution.