The Notify Slack Form is not depending of a permission to be accessible, why the access to this form is not secure ?
Everybody can use the form if the URL is known !!! That's crazy !!!

$items['notify_slack/form'] = array(
  'title' => 'Notify Slack Form',
  'page callback' => 'drupal_get_form',
  'page arguments' => array('notify_slack_form'),
  'access callback' => TRUE,
  'description' => 'Send notification to Slack.',
  'type' => MENU_NORMAL_ITEM,
);

I suggest to do a refactoring of the permissions management for this module.
For the settings page the access arguments is also too generic, but secure in this case ;)
'access arguments' => array('administer site configuration')

Comments

Echofive created an issue. See original summary.

Echofive’s picture

Here the patch that I've created ;)
If this can help somebody ;)

Echofive’s picture

Status: Active » Needs review

Issue status update ;)