When strict error reporting is on you get a whole bunch of warnings:

    * Strict warning: Static function Notifications_Object::object_load() should not be abstract in _registry_check_code() (line 2662 of X:\xampp\htdocs\drupal7\includes\bootstrap.inc).
    * Strict warning: Static function Notifications_Object::object_name() should not be abstract in _registry_check_code() (line 2662 of X:\xampp\htdocs\drupal7\includes\bootstrap.inc).
    * Strict warning: Static function Notifications_Object::object_value() should not be abstract in _registry_check_code() (line 2662 of X:\xampp\htdocs\drupal7\includes\bootstrap.inc).

http://stackoverflow.com/questions/999066/why-does-php-5-2-disallow-abst...

Attached patch uses an interface (if you start using a interface you might want to consider adding more of Notifications_Object's methods to the interface).

CommentFileSizeAuthor
notifstrict.patch1.63 KBcasey

Comments

fangel’s picture

fangel commented

I concur with these changes. I also run with strict warnings enabled and receive the following notices when e.g. clearing cache..

sharplesa’s picture

sharplesa commented

Could not duplicate. Am on PHP 5.3, though.

In index.php, I've set 


error_reporting(E_ALL|E_STRICT);

Please describe procedure for getting these error messages. Otherwise, I'm inclined to recommend a status change of "closed (cannot reproduce)".

sharplesa’s picture

sharplesa commented
Status: Needs review » Needs work

This issue report needs work, so rolling status back to "needs work".

webflo’s picture

webflo commented

Confirmed. Set your error_reporting to -1.

webflo’s picture

webflo commented
Status: Needs work » Fixed

Thanks. Patch committed in a248732 on 7.x-1.x. Will cleanup later.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.