Closed (fixed)
Project:
Nodequeue reference
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 Nov 2013 at 10:15 UTC
Updated:
30 Jul 2015 at 19:31 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
beltofteComment #2
chetan-singhal commented@beltofte
add dependencies in nodequeue_reference.info file
dependencies[] = references_dialog
Comment #3
beltofte@chetan_singhal
Thats the solution here, because the module should work without a dependency on references_dialog module. I will fix the issue be adding some module_exist() checks where functions from references_dialog is called.
Comment #4
chetan-singhal commented@beltofte
But I got fatel error
undefined function references_dialog_in_dialog()
Comment #5
beltofteYes, and I'm not saying that you do not. The solution is not adding the dependency in the info file, because the module is architected to work without the references_dialog module, but it has one or two places where it is not checking if the references_dialog module exists. As I wrote will I fix this.....
Comment #6
jibranHere is the fix same as nodequeue_reference.module:35
Comment #7
caspervoogt commentedjust wanted to say this patch worked for me.
Comment #8
damienmckennaComment #9
damienmckennaThis works, but might it also be useful to only enable the 'nodequeue-reference/dialog/redirect' path if the module's available in the first place.
Comment #10
beltofte@DamienMcKenna: Thanks for helping out to get 1.2 release out.
One comment to the patch. Will it actually work when Drupal is rebuilding the menu items and caching them? I mean references_dialog_in_dialog() is checking if $_GET['render'] == 'references-dialog' and not if the references_dialog module exists. It would make sense to change the if in nodequeue_reference_menu() to module_exists('references_dialog'), right?
Comment #11
damienmckennaDuh, sorry, was distracted when I did the patch. This adds the module_exists() call, as expected.
Comment #12
beltofteThanks. I will commit it and the other patches tomorrow morning at work.
Comment #13
damienmckenna@beltofte: Excellent news! Thanks!
Comment #15
beltofteI have comitted the two patches. Thanks for helping out fixing the issue :-)