It would be nice if the module offered a way to either reuse the popup window or somehow close it when the node is submitted (neither happens on Safari). For the latter, the simplest solution is a link; one could argue, however, that the window closing is confirmation of success, since failure would leave the window open with the problem highlighted.

Comments

Egon Bianchet’s picture

Egon Bianchet commented

It could work like this:

If there is no error message, wait 2 seconds, then close the window, else leave it open

admincyma’s picture

admincyma commented

Good idea for the time out. In the same vein, a CANCEL button (that closes the window) could be useful as well (next to preview and submit).

And note that right now if there is an error, the form is refreshed, the problem fields are red, but there is no message displayed in the window. I had the error messages displayed on the Drupal site a couple of times. Should I post another issue or do you consider them all related?

Thanks for the support so far.

Egon Bianchet’s picture

Egon Bianchet commented
Status: Active » Fixed

I've implemented the new features, except for the cancel button. I'm not sure about it ... isn't the window close button sufficient?

admincyma’s picture

admincyma commented

Yes, if it is there, the close box provides the functionality. I was just thinking a cancel button could be easier for non web experts. Because of our understanding of the web model, we know that unless we commit, nothing has been saved in the DB. It may not be the case for everybody, and an explicit 'CANCEL' button fixes it, for a negligible cost IMHO.
Thanks for the fixes, will try them and report any issue with them.

Egon Bianchet’s picture

Egon Bianchet commented

That's a valid reason, but it think that it belongs to Drupal core. Having a cancel button on popup but not on regular forms would be inconsistent ...

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)