Greetings,

Thanks for the module. I've been playing around with jscripts (ugly) to add bookmarks. Your mod makes it much easier and cleaner for the user. I installed it and set it up with blog and weblinks content types; but I get a page not found when I try to blog or submit a link. I'm using drupal 4.7.3. BTW, i changed weblinks module using your patch from http://drupal.org/node/71295.

Kind regards,

Jim

Comments

Egon Bianchet’s picture

Status: Active » Fixed

Fixed :-)

jwilde’s picture

Hi,

I had to change your fix, $url = url('nodeformpopup/add/'. check_plain($type), 'destination=nodeformpopup/submitted', NULL, FALSE); to $url = url('nodeformpopup/add/'. check_plain($type), 'destination=nodeformpopup/submitted', NULL, TRUE); to make it work.

I have another problem. I get a page not found if I try to bookmark links that have, html?, in them. If I add a slash after the html question mark, the bookmark is grabbed and I can save it. I tried both, the storylink module and the weblinks one, and get the same problem.

http://www.nytimes.com/2006/08/06/sports/othersports/06landis.html?hp&ex...

http://www.wired.com/news/technology/internet/0,71387-0.html?tw=wn_index_3

I looked through both modules and they have code, preg_match('/^(http|https):\/\/[a-z0-9]+([\-\.]{1}[a-z0-9]+)*\.[a-z]{2,6}((:[0-9]{1,5})?\/.*)?$/i', $url)) {

that looks like it is validating the url. Any ideas on how to fix this?

Jim

Egon Bianchet’s picture

I committed the change in the url function call, thanks.

I can't replicate the problem with "html?" ... did you update the bookmarklet after you changed the url function call?

jwilde’s picture

Hey Egon,

Thanks for your help. I'm using storylinks from the vote up/down package for bookmarks. I used your form changes to make storylinks work with your nodeformpopup. So far so good. I hit a snag when I try to edit the storylink. I get the title and desc but not the url. I tried to change the code in storylinks but it is too much for me right now. Any ideas or suggestions?

Thanks,

Jim

Egon Bianchet’s picture

I submitted a patch here http://drupal.org/node/77602

Anonymous’s picture

Status: Fixed » Closed (fixed)