Now that #1733658: Inject a comment body text area and input format selector into the node edit form is committed, there's already a place you can put the comment body and input format selection into $node so that it'll be used when generating the comment for a given revision, namely $node->nodechanges_comment_body['value'] and $node->nodechanges_comment_body['format']. Therefore, I'd like to propose we rip out the support for $node->nodechanges_body and $node->nodechanges_format and teach the migration code that's relying on that to use the better-namespaced ones, instead.

However, this isn't blocking launch, so I'm not even tagging for Drupal.org D7. Just wanted to capture this into an issue so it doesn't get lost when I close #1733658.

Comments

dww’s picture

Assigned: Unassigned » dww
Status: Active » Needs review
StatusFileSize
new757 bytes
new1.2 KB

Now that I know where the migrate code lives, I wanted to post a proof-of-concept for what I'm talking about here.

drumm’s picture

Issue summary: View changes
Status: Needs review » Needs work

The nodechanges patch looks good, but no longer applies. At least in the Drupal.org codebase, there are no references to "nodechanges_body" other than this.

drumm’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.