While looking trough the code to figure out a way to fix #2051267: block does not get deleted if using custom machine name I found out that db_select is being called once for each nodeblock enabled content type. The code in nodeblock_block_info could be rewritten to only use one query.

I'm already working on a patch which I will add shortly

CommentFileSizeAuthor
#1 nodeblock-reduce-queries-in-block-info-2053931-1.patch1.79 KBlegolasbo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
CreditAttribution: legolasbo commented
Status: Needs work » Needs review
FileSize
nodeblock-reduce-queries-in-block-info-2053931-1.patch1.79 KB

Attached patch only uses one query to fetch all the required info from the db.

Johnny vd Laar’s picture

Johnny vd Laar CreditAttribution: Johnny vd Laar commented
Status: Needs review » Fixed

Added your change here:
https://drupal.org/node/129257/commits

thanks for the help!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.