Excessive File Permissions

Looks good to me!

I strongly disagree with this issue, but I was willing to apply your patch anyway since you went to the trouble to create and review it - then I was going to tell you that the patch would likely regress the next time changes were made to the module.

However in applying the patch and trying to commit the changes I received the error "No changes detected".

That pretty much confirms to me that this is not a project issue. I believe this is something the Drupal.org packaging script should handle.

The reference page you've provided is a guide for site owners and administrators regarding files on your own file system and in permissions that are a feature specific to your operating system. It makes no mention of a module developer's responsibility regarding file permissions. I've searched everywhere, nothing does.

If something said I have to set file permissions a certain way I wouldn't even be able to do it. It is not practically viable since permissions work differently from OS to OS.

If you disagree take it up with the Drupal.org security team.

I was able to apply your changes via this method https://www.drupal.org/node/1189520