Problem/Motivation

If the default "Minimum number of revisions to keep" is zero and I do not override the value on a content type, then I cannot save the content type. The error is the standard error given when a required field is not completed.

Proposed resolution

This can be fixed by removing #required from the "Minimum number of revisions to keep" form component, but there is probably a better fix.

Remaining tasks

Figure out the best fix. Implement.

User interface changes

Able to save content types.

API changes

None.

Data model changes

None.

Issue fork node_revision_delete-3585263

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

liam morland created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@liam morland thanks for the bug report. Will fix this asap.

alexpott opened merge request !72

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Reviewed & tested by the community

Manually tested both with and without JS. Added test coverage that fails without the fix.

  • alexpott committed 71e795e5 on 2.1.x 
    fix: #3585263 Unable to save content types when not overriding number of...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@liam morland thanks again - any other feedback on 2.1.x would definitely be appreciated.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Thanks. It looks like the merge request can be closed.

alexpott closed merge request !72

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.