Delete revision by life time

Exact same reason I'm here and looking at the module myself.

Subscribing and willing/eager to contrib too, if i'm lucky.

I am working on it and update the same when its completed..

kaushalrahuljaiswal thank you for the reply!

I took a look at the module code and it is so clean and clever. Very nicely done, I love looking at others code and learning things myself.

If you need any help or want some testing done, don't hesitate to ask I would love to help someone as organized as you out with a task.

Ryan

kaushalrahuljaiswal, I went ahead and implemented this for myself, I also added the option to dry-run the operation so you can preview the effects.

Patch attached!

Last patch contained a debug setting form my own use, use this patch instead!

Hello Murz / Ryan.merritt,
I have updated my code, and you can get the unstable release on the below link. Can you all please check it on your systems that It is working properly or not. Now it also provides the feature for time selection, whats the "Murz" want.
http://drupal.org/node/1779880/release

I have update the code to solve this issue.

Sorry, there is no commit to repo.

Sorry, my fault. Would be nice to announce repo link here.

So this has been committed or not?

Last patch in this issue simply breaks and does not apply correctly. Please, state if this has been committed or if there is github link to the correct patch. thanks.

Code in #6 is horrible, a lot of code which is suposed to be removed it is already/even not there! From which version was this patch made?

Ok I see, 7.x-1.x-dev. Changing to 7.x-2.x which is the only existing.

Re-rolling against the last dev version

Thanks for the patch(es):

1. +++ b/node_revision_delete.module
   @@ -136,8 +140,38 @@ function node_revision_delete_cron() {
   +  // Figure out whether we should remove revisions or not based on life-time
   

   Nitpick - comments should end in full stops.

2. +++ b/node_revision_delete.module
   @@ -146,7 +180,12 @@ function node_revision_delete_cron() {
   +          // Decide whether remove or not the revision by life-time
   

   Nitpick - comments should end in full stops.

3. +++ b/node_revision_delete.module
   @@ -309,6 +348,7 @@ function node_revision_delete_form($form, &$form_state) {
   +    'dry_run' => 'Test run now without deleting and output result',
   

   This (and the others before it) should be wrapped in the t() function.

Thanks @kiwimind

Here is the new patch.

I changed the form element order in this patch.

+++ b/node_revision_delete.module
@@ -163,12 +212,12 @@ function node_revision_delete_cron() {
+ *   The nid of the node whoose oldest revisions will be deleted.

Sorry, getting super picky now, but think it's worth getting right - typo: 'whose'

Looking good.

Patch applies cleanly to 7.x-2.x.

Sorry, not tested functionality as don't have use case for this module at the moment.

Thanks.

@RaulMuroc I take your idea and I will add this functionalities in the Drupal 8 version of this module, see this:

https://github.com/adrian-cid/node_revision_delete/issues/15
https://github.com/adrian-cid/node_revision_delete/issues/14

For the moment we will stop the new features in the 7.x branch because we are adding new features in the 8.x version and once it will be finish we will add the new features to the 7.x branch.

Thanks for your code and will be great if you can help me in the migration, take a look here:

https://github.com/adrian-cid/node_revision_delete/projects/1

and here:

#2808383: Node Revision Delete Drupal 8 port

I'm creating another issue #2888577: Add a dry-run option to handle the dry-run option.

I'm closing this because #2892807: Use the minimum_age_to_delete and when_to_delete variables to delete revisions is more general, I will add credit of all the users that help in this issue.

Thanks to @all.