Unpublishing the Gallery does not unpublish any of the images that belong to that Gallery

Mhm, we can do this with Triggers/Actions Bulk API, some manual loading and saving of nodes, or directly in the database. I'll leave this decision to justin. Here is a patch to directly do it in the database.

Greetings
scroogie

Ah, you're right indeed. I guess the manage and sort images tab should show unpublished images.

The image count is correct in my opinion, because unpublished images are just that: unpublished. They shouldn't be counted for images in a gallery, or do you think differently?

For now, you can change the manage images thing in the related View, but I guess we should change the default. Justin, what do you think about that?

OK, so for the manage and sort issue, I created #956638: Unpublished images don't show up in Manage and Sort tabs.

Agree with the image count being correct. Anonymous users should not see any data related to unpublished nodes.

Regarding your patch, it works, but there's problems with going the direct to the db route. The problem is that other modules may want to perform operations on these nodes when they are unpublished, and you're bypassing nodeapi by going that route. Instead, we should node_load()/node_save() each image that needs modified. Since that's a fairly expensive operation and there's the potential for 100's or even 1,000's of images here, we should use batch API. Code similar to the cascading deletion should do well here.

Also bumping this to critical so it makes the alpha.

So perhaps we should show a confirmation dialog for this?

This one is with batch API. I reused the node_gallery_batch_node_save function that was already there.

Greetings
scroogie

Nice patch @scroogie - I didn't know PHP had anonymous functions - reminds me of my Perl days :)

I cleaned a bunch of stuff up and rerolled it. Not much functional difference, just a lot less repeating ourselves. @3dloco (or anyone else), could you test the updated patch and report back?

setting status back to needs review

Ah, yes, thats better indeed. But are the escaped variables on purpose?

Yeah, that's intentional. I needed $status to be interpolated, but the other variables to not be. The php.net docs for create_function explain that variable interpolation is usually prevented by using single quotes, but I had to switch to double quotes to allow interpolation of $status. Thinking about it now, I probably should have used $status as an argument. Oh well.

Sweet. Committed to dev with the changes mentioned in #10 for clarity