Needs review
Project:
Node Gallery
Version:
7.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
14 Aug 2014 at 13:40 UTC
Updated:
8 Oct 2014 at 13:31 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
siltaar commentedComment #2
zengenuity commentedThere should be an option in the admin interface somewhere to turn this off. Defaulted to off, actually.
Comment #3
siltaar commentedSounds reasonable, will provide.
Comment #4
siltaar commentedWould you prefer a "one for all" switch in /admin/config/content/node-gallery/settings or a by-role right to see the Download link ?
The second option looks more flexible to me, but will display the Download link to the main Drupal admin.
I may work on a "download the full gallery" feature like in Picasa afterwards. Being able to actually share your photos is just needed on my point of view.
Comment #5
zengenuity commentedI don't think we really need a permission for this. My chief thing is that I don't want a future update to cause changes to people's existing galleries. That's why this should be optional and turned off by default. A global option is probably sufficient for this.
Comment #6
siltaar commentedSo, bringing all together would be to add a global option which unlock a new permission.
I would have brought-by-Drupal level of access management, and you would have backward compatibility.
We might consider dropping the global option overhead while upgrading to Drupal 8…
Comment #7
zengenuity commentedI still don't think the permission is really all that necessary, but if you add it, make sure to add some instructions on the global enable/disable option to point people to the permission. Otherwise, people will turn it on and then be confused why it doesn't work.
Comment #8
siltaar commentedDone as soon as said (cof-cof…).
Comment #9
zengenuity commentedComment #10
zengenuity commentedThanks for your work on this patch. There are few issues with it before I can commit:
Comment #11
siltaar commentedHi,
I will work on the 1sts points.
Regarding the 4th, the HTML5 download attribute of links may be used :
- https://developer.mozilla.org/fr/docs/Web/HTML/Element/a
- http://caniuse.com/#feat=download
But I'm personnally happy with the current behavior. I may add one more checkbox in the Other Settings panel to allow both behaviors, defaulting on the one you asked for.
Comment #12
siltaar commentedComment #13
siltaar commentedComment #14
siltaar commentedFixed points 1 to 3.
For point 4, I add an extra preference, linked to the main full sized image downloading preference.