Closed (fixed)
Project:
Node Gallery
Version:
6.x-3.x-dev
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
23 Jul 2011 at 03:44 UTC
Updated:
4 Jan 2014 at 01:11 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
crea commentedComment #2
dddave commentedWould this break existing translations if changed?
Comment #3
crea commentedYes, but since 3.x is not stable yet, I thought it would be ok
It is acceptable practice that strings can change during development before stable releases.
Comment #4
dddave commentedBasically I agree yet I am not motivated to work on the German translation again. On the other hand this affects no THAT many strings.
Comment #5
dddave commentedFrom all the new issues I think this is the only one which can be considered a release blocker for a final full release as it affects translations in a possibly big way. I don't think we want to break translations in such a way after 3.0 is out.
@justintime
Do you agree?
I think the rest of crea's input can be dealt with after 3.0 is shipped. The priority should be to crown all your hard work with a full release (which most likely will raise the usage numbers even more). Don't shy away from breaking my translation as I knew the risk when I started working on this.
Comment #6
justintime commentedAttached patch is actually two commits. The first is coder recommendations, the second address the t() calls with backslashes.
Comment #7
dddave commentedI cannot get this patch applied using cygwin. Is this drushyfied?
Comment #8
justintime commentedIt's a git format-patch, and I doubt cygwin's patch command works with those. I created a diff style one that should work for you and attached it to this issue.
Comment #9
dddave commentedThanks. Shouldn't this replace certain strings? I extracted a .po file and only the new og-related strings are added while the rest seems intact...
Maybe I am doing something wrong here. I am tired anyways. Will look into this tomorrow.
Comment #10
justintime commented@dddave, I wondered whether or not that would impact your translation or not. The only thing that I changed was removing some backslashes, and changed a couple single quotes to double quotes and vice versa. I would've thought you'd have reported seeing backslashes in your .po file.
In light of this, I'm just committing it. I'm guessing there's little to no work for you to do there.
Comment #11
dddave commentedTo be honest I was wondering about those backslashes and quotes. However the translation worked fine and I didn't bother. I never cared about the coding side in this respect and a lot of modules I worked on ignored the 100% correct usage of t() anyways.
edit: You got mail.