Closed (won't fix)
Project:
Node Gallery
Version:
6.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Jul 2011 at 08:49 UTC
Updated:
24 Sep 2012 at 16:55 UTC
1. Are the content type descriptions correctly wrapped in t()?
2. The link "rotate" is not translatable. Can we do something about this?
Comments
Comment #1
justintime commentedI committed the fix to #2 to dev just now.
As to #1, it's a bit trickier, because the content type is imported upon install. I don't have a clean install to test this on, can you try this for me and see if it fixes it?
1) Setup a clean install of d6 and the NG prerequisites.
2) Download ng3, but *don't enable it yet*
3) Edit both *.cck files under the node_gallery/cck_types directory, and encapsulate the description string with a t(). For example, change line 4 in node_gallery_image.cck so it looks like:
'description' => t('This is an individual image that will be linked to a gallery.'),4) Install the module.
5) See if it's translatable then.
Comment #2
dddave commentedI am going to test this but it may take a while as I am away from my dev instal.
Comment #3
dddave commentedStill not tested (I'll have time tomorrow) but perhaps you could check how NG2 did it? I remember translating the content type descriptions for NG2.
Comment #4
justintime commentedYep, found how it was done in NG2, and committed a fix to dev.
Just a note for you - I have a feeling a lot of the strings in the views may not be translatable. The views UI may handle t() for us, if not I'll need to make some edits.
Marking as needs review so I can get a confirmation on whether I got everything or not.
Comment #5
dddave commentedI'll have to wait for the next dev built. In the meantime I am going to work on the outstanding translation issues and with the next release I'll upload my files to localize.drupal.org.
#views
I now about this and we might receive some support requests concerning this as views+i18n in D6 is far from perfect.
Comment #6
dddave commentedIt seems the dev from the 15th lacks the fix you mentioned for the content type translation (or the fix doesn't work).
Comment #7
justintime commented@dddave, you need to at least uninstall and remove the content types, then re-install for the change to take place.
Comment #8
dddave commentedI'll have to translate those strings directly on localize.drupal.org. I have a local install using the aquia stack and I cannot extract those strings without bigger problems.
Comment #9
zengenuity commented