Hi Alan,

just trying to decide which one of the similar modules (Name or CCK_Fieldname) I must take, so I'm only working from the project pages provided info.

I see that you haven't mentioned Diff support, while the other project has.

Have no idea in this stage for what practical purposes one can use that, but probably its an easy step to get that into this already very rich module, if its not included already?

Then I will install "Name" instead of CCK_fieldname, but I'm only a bit hesitating about a possible name change. If the name of "Name" is changed soon, then I have to reinstall. Should I wait for this projects possible name change before uninstalling CCK_Fieldname and installing this module?

CommentFileSizeAuthor
#2 name-diff-2.jpg11.53 KBalan d.

Comments

ClearXS’s picture

Title: Diff support; difference with CCK Fieldname and renaming this module? » Diff support; difference with CCK Fullname and renaming this module?

About your comment here: http://drupal.org/node/266858#comment-3524836

Its not clear to me: project technical name = "name", projects human name ="Name Field".

If the technical name is changed too, to "name_field", then its gives problems for updating from "name" to "name_field" module for D6.

alan d.’s picture

Title: Diff support; difference with CCK Fullname and renaming this module? » Diff support
Status: Active » Needs review
StatusFileSize
new11.53 KB

diff

Decide on which of the 3 outputs you prefer?

#1 is a cleaned name printed with spaces between components.
#2 is a cleaned name printed with "~" between components.
#3 is every component printed using "~" to separate these.

I like the first, but it is hard to tell if they have moved a component from one field to another, and multipart names are difficult to judge the boundaries between components.

regarding the name

No, I'm not changing the technical name, just the project page title (I probably have to update the .info file at some stage to)

I decided on very generic name "Name" as CCK => Fields was in full swing, but Field does seem to have caught on. From Rays suggestion, moved to Name Field, but the code name, or module prefix or Drupal URL, etc, is staying as name.

alan d.’s picture

The code for number 3 is:

<,code>

/**
 * Implementation of CCK's hook_content_diff_values().
 */
function name_content_diff_values($node, $field, $items) {
  $return = array();
  foreach ($items as $delta => $item) {
    $return[] = implode('~', $item);
  }
  return $return;
}

alan d.’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Active

Committed #3. Needs porting to Drupal 7 version.

alan d.’s picture

The current Diff implementation is nasty. Will try and get a push for the Diff 7 api to be modified before returning to this...

alan d.’s picture

Status: Active » Fixed

I've pushed through a version that supports the new Diff 7.x-3.x branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mitchell’s picture

Issue tags: +Diff integration

Retroactively tagging.