After installing the "name" module, when I edit any field (or create a new one) additional explanation for the "name module" displays at the bottom. Expected behavior is to see this help text only when the field type is "name".

Namely, even when the field type is not "name", the following text is displayed after "default value"

Field Title Given Middle name(s) Family Generational Credentials

  1. The title display controls how the label of the name component is displayed in the form. "above" is the standard title; "below" is the standard description; "hidden" removes the label.
  2. The HTML size property tells the browser what the width of the field should be when it is rendered. This gets overriden by the themes CSS properties. This must be between 1 and 255.
  3. The inline style property tells the browser what the width of the field really should be when it is rendered. This is dynamically calculated from the HTML size property.

and at the very bottom just after the allowed values section the following text is displayed:

Field Title Given Middle name(s) Family Generational Credentials
Sort options 5

  • Only selected components will be activated on this field. All non-selected components / component settings will be ignored.

    Warning! Changing this setting after data has been created could result in the loss of data!
  • The minimal set of components required before considered the name field to be incomplete.
  • The maximum length of the field in characters. This must be between 1 and 255.

    Warning! Changing this setting after data has been created could result in the loss of data!
  • The labels are used to distinguish the fields. You can use the special label "" to hide this.
  • This enables sorting on the options after the vocabulary terms are added and duplicate values are removed.

    • This is show stopper since help text becomes confusing for content providers.

    Comments

    osman’s picture

    osman
    Location Copenhagen
    commented

    ditto.

    subscribing.

    alan d.’s picture

    alan d. commented
    Status: Active » Fixed

    Sorry, no testing of Drupal 6 stuff at the moment, but I think that I found and just committed a fix in the latest dev version. A quick fix is to ensure that the following condition is meet in the name.module code: 

    /**
 * Provides a hook into the theming of the field and instance settings, using
 * #pre_render callbacks.
 */
function name_form_content_field_edit_form_alter(&$form, &$form_state) {
  $field = $form['#field'];
  // Wrongly set, maybe left overs from debugging
  $field = $form['#field'];
  if (!$field['module'] != 'name') {
    return;
  }

  // Change to:
  $field = $form['#field'];
  if ($field['module'] != 'name') {
    return;
  }

    This is removing the ! from the very start of the if statement (between the "if (" and "$field").

    alan d.’s picture

    alan d. commented

    [edit: double post]

    Status: Fixed » Closed (fixed)

    Automatically closed -- issue fixed for 2 weeks with no activity.