Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Status: Active » Needs review
FileSize
12.79 KB

This at least will make the transition easier to one unified 'Multifield' field type.

attiks’s picture

@Dave Reid do you want to commit this first, before #2041533: Add Views API integration for the multifield field type and/or #2102265: Features integration? Just so we know how to reroll everything

Dave Reid’s picture

I'd like to get the Views integration in first, but looking at the Features integration, and reviewing what Field collection does, makes me kind of like that no special magic is needed for exporting Field collections. You just have to export the field collection field, and the subfields, and it just works. If we had one 'Multifield' field type, we could do the same, and we wouldn't even need the multifield table itself, which I would be ok with.

Dave Reid’s picture

Ok looks like this is all that's needed to deprecate the old field type and start to encourage people to use the official 'Multifield' field type.

Dave Reid’s picture

Made sure to update field schema when adding instances to the new multifield type.

The last submitted patch, 4: 2234769-multifield-field-type.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 5: 2234769-multifield-field-type.patch, failed testing.

Dave Reid’s picture

Status: Needs work » Needs review
FileSize
33.2 KB

Ok this one has even more test coverage, and workaround for a core bug with field_update_field() "remembering" old indexes in field schema that are no longer wanted.

Dave Reid’s picture

Found an interesting core bug as a result of this: #2311095: field_update_field() fails if a field schema removes an index

Dave Reid’s picture

Dave Reid’s picture

Added very basic Features integration so that a multifield is exported properly.

Jelle_S’s picture

This patch includes the (rerolled) patch from #2041533-49: Add Views API integration for the multifield field type.
Views integration seems to work as it did before with that patch.

Dave Reid’s picture

Status: Needs review » Fixed

Committed #11 to 7.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs review
DamienMcKenna’s picture

Status: Needs review » Closed (fixed)

@tufy: There's no point in re-testing a patch that has already been committed, just grab the latest -dev release.

Mixologic’s picture

Status: Closed (fixed) » Needs work

I have a question on this. Is there some reason that 'no_ui' => TRUE is needed in there? it makes it so that you cannot re-use a multifield on different bundles, or even have multiple instances of the same multifield on the same entity, like you could before this patch.

ciss’s picture

@Mixologic: From what I understand it only affects instances that have been created in an earlier version of multifield. This would be the deprecation of the old field type that has been mentioned in several places.

Dave Reid’s picture

Status: Needs work » Closed (fixed)

Correct, using 'no_ui' only apples to the old, deprecated field type. You can still use the field API functions to create instances, adjust settings, etc. if needed.

Status: Closed (fixed) » Needs work

The last submitted patch, 12: 2234769-multifield-field-type-12.patch, failed testing.

ciss’s picture

Status: Needs work » Closed (fixed)