update.php warning when updating from 6.x-1.x-dev (2/24) to 6.x-1.6

warning: array_merge() [function.array-merge]: Argument #2 is not an array in xxx/update.php on line 174.
warning: Invalid argument supplied for foreach() in xxx/update.php on line 338.

database successfully updated and no errors on subsequent updates.

Comments

alexbk66-’s picture

alexbk66- commented

subscribing

How do you know if DB is updated? I get:

module_filter module
Update #6100
No queries

I think I revert this update until it's sorted :(

echoz’s picture

echoz commented

Ah, for me too. Looking at this further, update 6100 is a function that deletes 'module_filter_autocomplete' from the variables table. I have a few duplicate sites to compare, so I can see that even on the databases where I didn't run the update, I never had the setting for 'module_filter_autocomplete'. I'm thinking perhaps the warning is when it tries to delete it but doesn't find that setting.

greenskin’s picture

greenskin commented
Status: Active » Fixed

Just pushed a fix to dev. The issue was I forgot to return the $ret array of updates applied. The update (deleting the variable 'module_filter_autocomplete') still gets applied even with the error. Probably for most people the variable doesn't exist, but the update will ensure it gets deleted if it does exist since the autocomplete functionality was removed.

alexbk66-’s picture

alexbk66- commented

BTW, "Module Filter" is one the best modules, it makes Drupal a bit more loveable! Thanks!

Archnemysis’s picture

Archnemysis commented

Thanks for explanation greenSkin.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.