save-configuration button width too big at german language

I have some hesitation with regard to changing the wording, I was thinking of adding a button to the bottom of the module list as well, moving the button there altogether might be an option and would resolve this issue.

As a user what are your thoughts on this change?

Perhaps we can make the tabs wider when the submit button is too big to fit? Either just make the tabs wider by default or self-adjust? I'm not particularly fond of duplicating the button. I find it confusing in instances when you see both buttons.

+1 for "Change the position". Is it possible to place the button under the "filter list" bar and above the table that shows the filtered modules? That way the button can be as wide as almost the whole page.

My usage has had me mostly scrolling back up the page to click the button..
Wouldn't it make more sense to place it at the bottom of the module list?

Just locate the button at the top and the bottom of the list (if that is possible), that would be super. With such a setup, the button is always nearby.

@radoeka: that was my initial intention, but the module creator is against it, http://drupal.org/node/1013914#comment-3897384

I find it confusing in instances when you see both buttons.

In that case: use a top and bottom button when there are more than 10 (my random number) modules in the list?
In case there are less buttons, use a bottom button. That would give the best of both worlds.
Just my 2 cents.

I've made some changes to add button at top and bottom as well as moving the button as discussed.

Please test the changes in 7.x-1.x-dev and give feedback before I package a release containing the changes.

Note: Build date of dev needs to be post 2011-Jan-04

Currently there is an option in the Module Filter settings to enable a dynamic save position. Right now it keeps the save button visible when tabs are longer than the page and as you scroll down it stays at the bottom until reaching the bottom of the tabs. My description doesn't do it justice but give it a try to better understand. I was planning on extending it a bit more to keep it at the top of the screen when scrolled past the tabs (much like table headers).

@greenSkin: this sounds something like what I originally wanted to to.. is this in the 7 code, or only in 6?

@realityloop It might be only Drupal 6 right now. I must have misunderstood your intentions. What I understood your idea was essentially creating a duplicate save button. What the setting implements is some JavaScript that merely keeps the box area, that contains the save button, visible.

@greenSkin I'll install it on a D6 site to check it out and see if I can port to D7.

@greenskin please try attached patch against D6 dev for example of what I had in mind.

Are you able to help with setting the width of submit button to table width?

I was thinking of something more along the line of the patch I've attached.

If the general consensus is to have the submit along the bottom of the table like in your patch then I'll jump on the bandwagon. Though, I am leaning towards keeping it where it is but make the tabs wider (would a min-width css setting suffice?) and add my patch to allow the submit button to always being visible.

I found that making the tab bar wider affected the width of the overlay in D7, which I think isn't too good, less of an issue with D6 however.

As no one has chimed in with a preferance I will get some feedback from users at Drupalcon this week.

Ok I've dicusssed the scrolling button with another friend who raised the valid point that if you are using a small display it makes it really hard to select things as it displays over the top of the module list checkboxes.

For usability reasons I'm now more inclined to stay with button at top and bottom of module list like I implemented in dev.

If I get no responses in the next few days I will updates for both D6 and D7.

Button change pushed to D7 release, @greenSkin are you ok with me backporting this change on the D6 branch?

@realityloop I just arrived in Chicago. I hope to be able to get online and test your version once more before saying yea or nay.

@greenskin, your at Drupalcon? I'm here too, we should catch up!

Hmm, I'm still hesitant. I feel it's fixing one issue (various languages make the save button too wide) while opening other issues. For example when viewing a group of project like the 'All' group and you are in the middle of the page you have to jump to the top or bottom to get at the button. This of course is fixable with some JavaScript much like what is done with the table header, but at this point not implemented. Also, the duplicate functionality I still am not a fan of (same button at the top as the bottom). The duplicate button would really not be useful if/when implementing an always visible save button. This floating button could get in the way of viewing the modules list.

For the Drupal 7 Overlay compatibility of the wider tabs I don't see how it would overlap the checkboxes and thus hide them. In the overlay the user should/could horizontal scroll at the least to right to view the list then back to the left to hit the buttom. With the latest dev for Drupal 6 the save button should always be visible based on vertical scrolling. Though it yet does not handle horizontal scrolls. This is perhaps the issue @realityloop mentioned about checkboxes betting blocked by the save button.

sub.

I've encountered this problem too. Will have a read/think and respond with thoughts on where the button should go - not sure resizing the tabs is a good solution (we should aim to be as agnostic about what the submit text could be as possible and resizing the tabs, while agnostic, could end up with a horrible UX).