Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork modal_dialog-3325780

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

marcusvsouza created an issue. See original summary.

WagnerMelo’s picture

WagnerMelo commented
Assigned: Unassigned » WagnerMelo

Hi, i'll work on it. XD

WagnerMelo’s picture

WagnerMelo commented
Assigned: WagnerMelo » Unassigned
Status: Active » Needs review

HI, i worked in this issue.
Please review it.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber

I wil review it.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned
Status: Needs review » Needs work

Hi @Wagner congratulations for your patch, it following drupal standards. I reviewed using these docs as parameter : (https://www.drupal.org/docs/creating-custom-modules/add-a-composerjson-file) (https://www.drupal.org/node/2471927)

Just one thing you should replace "GLP" in the line 5 to "GPL"

WagnerMelo’s picture

WagnerMelo commented
Assigned: Unassigned » WagnerMelo
Status: Needs work » Needs review

Hi, i'll work in this issues to solve the adjustment appointed by @elber.
Thanks for your review.

WagnerMelo’s picture

WagnerMelo commented
Assigned: WagnerMelo » Unassigned

I solved the problem appoint by @elber, i hope that everything is fine now, please review the changes.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber

I will do a review.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned
Status: Needs review » Reviewed & tested by the community

Hi I reviewed your fork and now the composer.json file is according Drupal standards, see .( https://www.drupal.org/docs/creating-custom-modules/add-a-composerjson-file)

I also ran "lando composer validate" and the output was "./composer.json is valid".

Moving to RTBC, congratulations Wagner.

WagnerMelo opened merge request !3

marcusvsouza’s picture

marcusvsouza commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.