it would be a nice to have if mobile_codes_generate() could also return the blank path of the mobile code. maybe something like this:


if($arguments['echo']) {
  return theme('image', $file, $arguments['name'], $arguments['name'], NULL, FALSE);
}else {
  return $file;
}
CommentFileSizeAuthor
#3 mobile_codes-DRUPAL-6--1-409958-additional_output_type.patch5.1 KBdeciphered

Comments

haggins’s picture

haggins commented

I wonder if there's a method to get the http status code of the nokia.com request. I think file_save_data() will create a file even when $image->data contains no image data. If so then this http code should be returned, too.

Thinking about all of it the return value should be an array:

return array(
  'image' => theme('image', $file, $arguments['name'], $arguments['name'], NULL, FALSE),
  'file' => $file,
  'status' => $image->code,
);
deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

Agree on both suggestions.

I will try to make some time in the next few days to look further into these.
Patches are always welcome.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Active » Patch (to be ported)
StatusFileSize
new mobile_codes-DRUPAL-6--1-409958-additional_output_type.patch5.1 KB

Here's a patch that adds the ability to output simply the filename. Will be committed to DRUPAL-6--1 once I have backported it for DRUPAL-5.

You have two options for outputting the file, an API call to mobile_codes_generate() (not overly recommended as it could change and break things) or via the newly supplied CCK/Views formatter.

As for the other issue, to simplify things for me, I will re-post that into a separate issue. (#410564: HTTP Status code)

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Patch (to be ported) » Fixed

Committed to DRUPAL-6--1 and DRUPAL-5.

haggins’s picture

haggins commented

works pretty well. thanks for the quick patch!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

calexo’s picture

calexo commented

Hi !
I don't manage to just get the image filename.
How could I call mobile_codes_generate ?
Thanks alot !

PS. My idea is to get 2 filenames for 2 sizes, and then using a lightbox display.