Unable to minify "sites/all/modules/jquery_update/replace/ui/external/jquery.cookie.js"
Attached the original file in zip.

CommentFileSizeAuthor
#20 warning-level-change_2226279_20.patch589 bytesidflood
#9 warning-level-change_2226279_9.patch721 bytesxpersonas
#7 desc-comment-minify-warning-2226279-7.patch3.89 KBgeorgemastro
jquery.cookie.zip1.42 KBnithinkolekar

Comments

atul.bhosale’s picture

atul.bhosale commented
Status: Active » Postponed

This error from Google closure compiler.

atul.bhosale’s picture

atul.bhosale commented
Status: Postponed » Closed (works as designed)
xpersonas’s picture

xpersonas commented

I don't want to annoy anyone by reopening this thread, but I'm having the same issue. For me, it's the jquery_update/replace/ui/external/jquery.cookie.js file. Which I know is not the responsibility of this module maintainer. However, when I run the code manually at http://closure-compiler.appspot.com/home I just get three warnings about the @desc, but it does in fact minify it.

So my question, or possibly suggestion if there is no objection, is should the minify fail due to simple warnings? Should we change the warning_level to "QUIET" rather than "DEFAULT" in the minify.admin.inc file? When I do that, I have no problems minifying it.

Or perhaps it would be a simple setting we could select on the configuration page? I'd be happy to add that code if needed.

xpersonas’s picture

xpersonas commented
Status: Closed (works as designed) » Active
xpersonas’s picture

xpersonas commented

deleted

yannisc’s picture

yannisc commented

Same problem here.

georgemastro’s picture

georgemastro commented
StatusFileSize
new desc-comment-minify-warning-2226279-7.patch3.89 KB

Just a temporary solution.

yannisc’s picture

yannisc commented

The above patch solved the problem for me!

xpersonas’s picture

xpersonas commented
StatusFileSize
new warning-level-change_2226279_9.patch721 bytes

Should we be patching to protect against that specific warning, or should warnings be preventing minification at all if they aren't really hurting anything? This may not be the right way to go either, but I'm putting my simple patch here in case anyone else wants it.

I'm simply changing the warning level to QUIET rather than DEFAULT.

osman’s picture

osman
Location Copenhagen
commented
Status: Active » Needs review

The last submitted patch, 7: desc-comment-minify-warning-2226279-7.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 9: warning-level-change_2226279_9.patch, failed testing.

atul.bhosale’s picture

atul.bhosale commented

This is already fixed and available in next soon release.

atul.bhosale’s picture

atul.bhosale commented
Assigned: Unassigned » atul.bhosale
Status: Needs work » Needs review

f.lacle@aruba.com queued 9: warning-level-change_2226279_9.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 9: warning-level-change_2226279_9.patch, failed testing.

coozila’s picture

coozila commented

subscribe

ryumkin’s picture

ryumkin commented

Subscribe

idflood’s picture

idflood commented

@Atul Bhosale I tried to clone the 7.x-1.x branch but the bug is still present. I'm also wondering why the dev version is not directly downloadable from https://www.drupal.org/project/minify like most other modules.

idflood’s picture

idflood commented
Status: Needs work » Needs review
StatusFileSize
new warning-level-change_2226279_20.patch589 bytes

The patch in #9 work perfectly but had the wrong base path (patching inside sites/all/modules/.. instead of the module directory). So here is a simple reroll of it.

xpersonas’s picture

xpersonas commented

Ah my bad. Sorry about that. Thanks!

fotispan’s picture

fotispan
Primary language Greek
commented

Patch works great for me too.

MRPRAVIN’s picture

MRPRAVIN commented

This patch works for me. Thanks.

nairb’s picture

nairb commented
Status: Needs review » Reviewed & tested by the community

  • Atul Bhosale committed 96a0562 on 7.x-1.x 
    - Bug fixes
- #2226279 Failed to generate minified JS. Error: Parse...
atul.bhosale’s picture

atul.bhosale commented
Status: Reviewed & tested by the community » Fixed

Fixed: warning level set to "QUIET"

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.