Problem/Motivation
Issues found:
metatag_ai_bulk_update.info.yml
1. core_version_requirement: ^9 || ^10 || ^11 — should be ^10.3 || ^11
2. Decorative comment block at top (non-standard)
composer.json
3. drupal/core version ^9 || ^10 || ^11 — should be ^10.3 || ^11
4. extra.drupal.core_version_requirement same outdated constraint
5. extra.drupal.package — redundant, package belongs only in info.yml
6. Missing support section
metatag_ai_bulk_update.module
7. Missing declare(strict_types=1)
metatag_ai_bulk_update.install
8. Missing declare(strict_types=1)
9. Missing @file docblock
10. Function docblock described removing fields/instances — completely
inaccurate (only deletes state)
11. Missing : void return type on metatag_ai_bulk_update_uninstall()
src/Form/MetatagAIBulkBatchForm.php
12. Missing declare(strict_types=1)
13. buildNodeText($node) — no type hint on $node parameter
14. BatchBuilder method chain incorrectly indented (aligned with new instead
of indented under the variable)
15. $validator->generate($text, FALSE) — passing extra argument FALSE that
generate() doesn't accept
src/Service/MetaTagAIValidatorOpenAI.php
16. Missing declare(strict_types=1)
17. getConfig() return type used FQCN \Drupal\Core\Config\ImmutableConfig
inline instead of a use statement
18. getParentConfig() same FQCN issue
19. extractApiSettings($config) — $config parameter had no type hint
20. Multiple docblocks had trailing space on blank * lines (e.g. * instead of
*)
21. Multiple docblocks had single-space @param/@return indent ( * The ...)
instead of three spaces ( * The ...)
22. Several @return tags had no blank line separating them from the last
@param
Missing files
23. .gitignore not present
24. .cspell.json not present
25. .gitlab-ci.yml not present
Issue fork metatag_ai_bulk_update-3580500
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3580500-Coding-standard-fixes
changes, plain diff MR !1
Comments
Comment #4
zeeshan_khan commentedFixed all the issues in release 1.0.1