The attached patch fixes a couple of typos in menutrails.module which hide the help text on the settings form.

It also adds the ability to allow the user to select which vocabs to set menu trails for.

The method is basically to select the categories to trail and they are then evaluated on save on the settings form.

This fixes loading issues when there are a large number of vocabularies / terms

Thanks for the great module! much appeciated :-)

DT

CommentFileSizeAuthor
menutrail.module.20071210.patch3.35 KBdavidwhthomas

Comments

psynaptic’s picture

psynaptic commented

Over 10 months and not a single reply. Shame on you!

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Closed (won't fix)

Well, the reason is simple - this patch tried to change too many things in one fell swoop, and even worse, does not adhere to Drupal's coding standards.

I believe something like the requested feature is already available in the D6 branch of this module.

Typos are already fixed in CVS, hence marking this issue as won't fix.

psynaptic’s picture

psynaptic commented

Ahh ok then, makes sense.

davidwhthomas’s picture

davidwhthomas commented
Status: Needs work » Closed (won't fix)

Can you be more specific about the requirements here?

Sites with a reasonable number of vocabularies or terms may crash on the default page as the module tries to build the menu tree select box for every single term and vocab.

All the patch does is allow selecting the vocabularies to apply trailing to on the admin settings page.

It provides a select box to choose the vocabs to trail and then on save shows those vocabs in their own fieldsets with terms for trailing.

I could run it through coder or similar if there are any code style issues but it looks fine to me.

I use this patch all the time.

regards,

DT

davidwhthomas’s picture

davidwhthomas commented
Status: Closed (won't fix) » Needs work
psynaptic’s picture

psynaptic commented
Status: Closed (won't fix) » Needs work

I can see a couple of minor code style points about the patch that should be fixed. Also, you should re-roll against the latest in CVS.

dafeder’s picture

dafeder
he/him
Location Philadelphia, PA
commented

Duplicate of #630312: Runaway javascript on admin page