Rename module hooks to avoid conflict with *menu modules implementing hook_node_*

Easier to rename the hook.

Got burned by this too.

Luckily this module provides a wrapper for the invoke, which means the code only has to change in one place (well, that and the menu_node.api.php file)

in _menu_node_invoke it has:

  module_invoke_all('menu_node_' . $hook, $link, $node);

Some suggestions for changing it:

  module_invoke_all('menu_node_invoke_' . $hook, $link, $node);
  module_invoke_all('menu_node_trigger_' . $hook, $link, $node);

Any other suggestions for a name? Willing to provide a patch if we can agree on a suitable name.

Better title.

*Bump

Can't believe I got burned by this again.
Attaching patch this time

didnt see the test module, updated patch

Patch looks good but it will break custom modules implementing the obsolete hooks. Perhaps we should do a check in hook_requirements() as to whether any other modules implement any of the obsolete hooks and throw a warning if so?

Havent written anything like that before. I'm willing to write it the next time I get burned by this issue ;)

Wanted to confirm this patch works for me. Maybe instead of worrying about legacy support, this patch gets rolled into a release with a major release number change and a short release note mentioning the change.

This module could use a new maintainer to push that through.

The patch works for me but I don't like that approach. It can potentially break something on at least 10k websites if they update the module once this is released.

I would rather look at this issue the other way around and check the value received in the hooks implementations done on og_menu.

This issue does not affect all modules ending with menu. It affects og_menu only because og exists and Drupal thinks that the function og_menu_node_insert/update/delete is part of the og module (more info available here #2601170).

So you suggest I add stupid checks to OG Menu code which may or may not cause issues while the real issue is poor naming of hooks here?
Well.. OG Menu is clearly outnumbered so I guess I should then :(

I agree the checks looks a bit silly, especially in a hook implementation, but I tend to think that it's a good practice to test the values we get as parameters instead of blindly relying on them.

In this case, I find it personnaly less risky to patch og_menu with the aforementioned checks than to change the poolry named hooks in a module containing API in its name :)

Or, alternatively, you could write your own module_invoke_all function to filter out the undesired function with a blacklist (exposed as a variable in the GUI).

Which sounds silly as well. Maybe I need some rest.

Let's do this as the menu hooks are core and the conflict there is likely more common.

Bump

OG Menu has been updated to 3.1 now, without any fix for this.

Hey guys any update on this, which approach is going to be used renaming the hook or module?

I close the issue as Fixed.